shortcuttrigger: Don't trigger on key releases
authorMatthias Clasen <mclasen@redhat.com>
Mon, 6 Apr 2020 23:16:41 +0000 (19:16 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Mon, 6 Apr 2020 23:16:41 +0000 (19:16 -0400)
This broke when the event type check in gdk_key_event_matches
was removed and replaced by a precondition that accepts both
key press and release events.

Add the check in gtk_keyval_trigger_trigger instead.

gtk/gtkshortcuttrigger.c

index 30ab0411ca5e9956a645aa667ab189ccd5b20447..e6c8c016f801b62a385ce88af4116623efe343a1 100644 (file)
@@ -516,6 +516,9 @@ gtk_keyval_trigger_trigger (GtkShortcutTrigger *trigger,
 {
   GtkKeyvalTrigger *self = GTK_KEYVAL_TRIGGER (trigger);
 
+  if (gdk_event_get_event_type (event) != GDK_KEY_PRESS)
+    return GDK_KEY_MATCH_NONE;
+
   return gdk_key_event_matches (event, self->keyval, self->modifiers);
 }